aiidateam / disk-objectstore

An implementation of an efficient "object store" (actually, a key-value store) writing files on disk and not requiring a running server
https://disk-objectstore.readthedocs.io
MIT License
15 stars 8 forks source link

Revert "Fixing mypy issue renaming database.py to db.py" #132

Closed giovannipizzi closed 2 years ago

giovannipizzi commented 2 years ago

Reverts aiidateam/disk-objectstore#131

Apparently this did not fix the issue, that was created by something else as discussed in #131

codecov[bot] commented 2 years ago

Codecov Report

Merging #132 (ad28b3c) into develop (9eda5b8) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #132   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files            8        8           
  Lines         1676     1676           
========================================
  Hits          1668     1668           
  Misses           8        8           
Impacted Files Coverage Δ
disk_objectstore/database.py 100.00% <ø> (ø)
disk_objectstore/container.py 99.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9eda5b8...ad28b3c. Read the comment docs.

giovannipizzi commented 2 years ago

@ramirezfranciscof can you check that this actually fixes the problem? (i.e. fixing the version of SQLAlchemy in the pre-commit config file). Also, I have the feeling that since this is only a change in the pre-commit, we don't need to release a new version of disk-objectstore, but you can apply the same fix in AiiDA probably?

If OK, can you please approve and merge this PR?

ramirezfranciscof commented 2 years ago

I see. It is unfortunate that changing the name of that file made the tests fortuitously start working again. I'll accept and merge this.

Also, I have the feeling that since this is only a change in the pre-commit, we don't need to release a new version of disk-objectstore, but you can apply the same fix in AiiDA probably?

The aiida-core repo doesn't have an additional_dependencies, can it still be problematic? Do I just add it and include only the line for - "sqlalchemy[mypy]==1.4.29"?