search

aiidateam / disk-objectstore

An implementation of an efficient "object store" (actually, a key-value store) writing files on disk and not requiring a running server
https://disk-objectstore.readthedocs.io
MIT License
15 stars 8 forks source link

DevOps: adopt PEP 621 and move build spec to `pyproject.toml` and update pre-commit dependency requirements #137

Closed sphuber closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (d81c737) into develop (16e6ff9) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #137   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files            8        8           
  Lines         1676     1676           
========================================
  Hits          1668     1668           
  Misses           8        8
Impacted Files Coverage Δ
disk_objectstore/container.py 99.39% <ø> (ø)
disk_objectstore/utils.py 99.60% <ø> (ø)
disk_objectstore/cli.py 98.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16e6ff9...d81c737. Read the comment docs.

sphuber commented 2 years ago

I'm approving, but @sphuber I have a question - the MANIFEST.IN is not needed anymore? It's now deleted but I don't see its content anywhere else. If it's a mistake, can you please fix? (Otherwise, can you please explain me how this works now?)

Indeed, the manifest is no longer necessary because flit is smart enough to include all package files, even non .py files. Any folders/files that shouldn't be included should be added in the pyproject.toml file under the [tool.flit.sdist] exclude list.