Hash key computed when writing directly to compressed packs is wrong

aiidateam / disk-objectstore

An implementation of an efficient "object store" (actually, a key-value store) writing files on disk and not requiring a running server

https://disk-objectstore.readthedocs.io

MIT License

15 stars 8 forks source link

Hash key computed when writing directly to compressed packs is wrong #73

Closed giovannipizzi closed 4 years ago

giovannipizzi commented 4 years ago

The hasher is applied in the wrong place (while writing rather than while reading) therefore it is hashing after compression. The hasher should run on the read data instead.

Tests should be added for this case (one example where 100% coverage does not mean bug-free...)
We should have a check that objects have the correct hash while packing