aiidateam / disk-objectstore

An implementation of an efficient "object store" (actually, a key-value store) writing files on disk and not requiring a running server
https://disk-objectstore.readthedocs.io
MIT License
15 stars 8 forks source link

Adding the `no_holes` and `no_holes_read_twice` flags #89

Closed giovannipizzi closed 4 years ago

giovannipizzi commented 4 years ago

These flags are added to the two functions to write directly to packs add_streamed_objects_to_pack and add_objects_to_pack.

In this way, it is possible to have all three behaviors:

Fixes #85

codecov[bot] commented 4 years ago

Codecov Report

Merging #89 into develop will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1175      1199   +24     
=========================================
+ Hits          1175      1199   +24     
Impacted Files Coverage Δ
disk_objectstore/container.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d977ad...0478501. Read the comment docs.