search

aiidateam / kiwipy

A python messaging library for RPC, task queues and broadcasts
https://kiwipy.readthedocs.io
Other
15 stars 4 forks source link

👌 IMPROVE: close loop on RmqThreadCommunicator.close #101

Closed chrisjsewell closed 3 years ago

chrisjsewell commented 3 years ago

The RmqThreadCommunicator creates a new_event_loop on initialising, and so on close it should also close it.

@muhrin can you think of any reason why this would be an issue?

codecov[bot] commented 3 years ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella: