search

aiidateam / kiwipy

A python messaging library for RPC, task queues and broadcasts
https://kiwipy.readthedocs.io
Other
15 stars 4 forks source link

πŸ‘Œ IMPROVE: BroadcastFilter #103

Closed chrisjsewell closed 3 years ago

chrisjsewell commented 3 years ago

For use with https://github.com/aiidateam/plumpy/pull/212

codecov[bot] commented 3 years ago

Codecov Report

Merging #103 (dff7db0) into develop (5efa84c) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
+ Coverage    90.25%   90.29%   +0.04%     
===========================================
  Files           16       16              
  Lines         1128     1132       +4     
===========================================
+ Hits          1018     1022       +4     
  Misses         110      110
Impacted Files Coverage Ξ”
kiwipy/filters.py 94.88% <100.00%> (+0.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 5efa84c...dff7db0. Read the comment docs.

chrisjsewell commented 3 years ago

Yep just a refactor cheers

sphuber commented 3 years ago

I updated the commit title to say REFACTORED instead of IMPROVE and even tried to replace the icon with the recycle arrows you use, but apparently copy pasting from a commit that uses the emoji doesn't work....