aiidateam / kiwipy

A python messaging library for RPC, task queues and broadcasts
https://kiwipy.readthedocs.io
Other
15 stars 4 forks source link

[BLOCKED] Server properties #107

Closed muhrin closed 2 years ago

muhrin commented 2 years ago

Exposes information about the RMQ server to communicator clients. Could be useful for AiiDA as this allows the version number to be determined.

chrisjsewell commented 2 years ago

Looks good, I'll wait for you to work out why all the tests are failing 😅

muhrin commented 2 years ago

Thanks, I'll try and figure out what's going on test side...

codecov[bot] commented 2 years ago

Codecov Report

Merging #107 (cb005ec) into develop (c35668d) will decrease coverage by 0.02%. The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #107      +/-   ##
===========================================
- Coverage    90.34%   90.32%   -0.01%     
===========================================
  Files           16       16              
  Lines         1138     1146       +8     
===========================================
+ Hits          1028     1035       +7     
- Misses         110      111       +1     
Impacted Files Coverage Δ
kiwipy/rmq/communicator.py 90.61% <83.34%> (-0.20%) :arrow_down:
kiwipy/rmq/threadcomms.py 93.79% <100.00%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c35668d...cb005ec. Read the comment docs.