aiidateam / kiwipy

A python messaging library for RPC, task queues and broadcasts
https://kiwipy.readthedocs.io
Other
15 stars 4 forks source link

Dependencies: Update requirement for `aio-pika~=8.2` #114

Closed sphuber closed 1 year ago

sphuber commented 1 year ago

The new major versions 7.0 and 8.0 come with important fixes that could improve the stability of robust connections, so the minimum required version is upped to ~=8.2.

The requirement for pamqp also had to be upgraded, since this is required by aiormq which is a direct dependency of aio-pika.

The newer version required a number of changes in the code:

codecov[bot] commented 1 year ago

Codecov Report

Base: 90.32% // Head: 89.63% // Decreases project coverage by -0.69% :warning:

Coverage data is based on head (9ae03e4) compared to base (0e7d02d). Patch coverage: 96.43% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #114 +/- ## =========================================== - Coverage 90.32% 89.63% -0.68% =========================================== Files 16 16 Lines 1146 1147 +1 =========================================== - Hits 1035 1028 -7 - Misses 111 119 +8 ``` | [Impacted Files](https://codecov.io/gh/aiidateam/kiwipy/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [kiwipy/rmq/tasks.py](https://codecov.io/gh/aiidateam/kiwipy/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-a2l3aXB5L3JtcS90YXNrcy5weQ==) | `95.56% <95.24%> (+0.47%)` | :arrow_up: | | [kiwipy/rmq/communicator.py](https://codecov.io/gh/aiidateam/kiwipy/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-a2l3aXB5L3JtcS9jb21tdW5pY2F0b3IucHk=) | `90.61% <100.00%> (ø)` | | | [kiwipy/rmq/messages.py](https://codecov.io/gh/aiidateam/kiwipy/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-a2l3aXB5L3JtcS9tZXNzYWdlcy5weQ==) | `93.53% <100.00%> (ø)` | | | [kiwipy/rmq/threadcomms.py](https://codecov.io/gh/aiidateam/kiwipy/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-a2l3aXB5L3JtcS90aHJlYWRjb21tcy5weQ==) | `88.20% <100.00%> (-5.59%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sphuber commented 1 year ago

@unkcpz I had only noticed your PR when I was already well on my way with this, apologies. I wanted to quickly tackle this because I am making a release for plumpy but this is breaking. As you can see, the tests are now running. Would be good if we can quickly review this so I can make releases all the way upstream to aiida-core and hopefully fix these dropping connection issues.

unkcpz commented 1 year ago

I wanted to quickly tackle this because I am making a release for plumpy but this is breaking

BTW, "quickly" is hurt 😄, I spend quite some time on this and failed to finish it.

sphuber commented 1 year ago

BTW, "quickly" is hurt smile, I spend quite some time on this and failed to finish it.

That's not what I meant to say :sweat_smile: I also spent quite some time, I just thought it was going to be a quick dependency upgrade, but it turned out to be more complex than that (as things always turn out to be :D). I also got stuck at some point and then came across your PR and your changes combined with the discussion with @muhrin definitely helped me put the final things in place.