Closed sphuber closed 1 year ago
Base: 90.32% // Head: 89.63% // Decreases project coverage by -0.69%
:warning:
Coverage data is based on head (
9ae03e4
) compared to base (0e7d02d
). Patch coverage: 96.43% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@unkcpz I had only noticed your PR when I was already well on my way with this, apologies. I wanted to quickly tackle this because I am making a release for plumpy
but this is breaking. As you can see, the tests are now running. Would be good if we can quickly review this so I can make releases all the way upstream to aiida-core
and hopefully fix these dropping connection issues.
I wanted to quickly tackle this because I am making a release for plumpy but this is breaking
BTW, "quickly" is hurt 😄, I spend quite some time on this and failed to finish it.
BTW, "quickly" is hurt smile, I spend quite some time on this and failed to finish it.
That's not what I meant to say :sweat_smile: I also spent quite some time, I just thought it was going to be a quick dependency upgrade, but it turned out to be more complex than that (as things always turn out to be :D). I also got stuck at some point and then came across your PR and your changes combined with the discussion with @muhrin definitely helped me put the final things in place.
The new major versions
7.0
and8.0
come with important fixes that could improve the stability of robust connections, so the minimum required version is upped to~=8.2
.The requirement for
pamqp
also had to be upgraded, since this is required byaiormq
which is a direct dependency ofaio-pika
.The newer version required a number of changes in the code:
pamqp
:specification.Basic.Ack
renamed tocommands.Basic.Ack
aio-pika
:types.CloseCallbackType
renamed toabc.ConnectionCloseCallback
Connection.add_close_callback
was replaced byConnection.close_callbacks.add
ack
andnack
methods were made asynchronousConnection.connection
moved toConnection.transport.connection