Closed muhrin closed 1 year ago
Apologies captain, thanks for jumping in. Anyway had to quickly make a 0.8.1
to unpin some very strict dependency requirements
Nae dramas, I think it'll be a quick fix.
Base: 89.54% // Head: 90.20% // Increases project coverage by +0.67%
:tada:
Coverage data is based on head (
5f503f1
) compared to base (50c729a
). Patch coverage: 90.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ok. I've fixed the problem. Turned out to be an upstream bug in pytray.LoopScheduler.
Long story short, it was propagating a future the wrong way around: instead of the result from a thread future being passed to the asyncio future, it was doing the opposite. Ultimately this meant that the RmqIncomingTask.processing()
context would never have a value in the future it was waiting on, and therefore assume that the task should just be requeued.
All fixed in pytray 0.3.4.
The release of kiwipy v0.8.0 made some breaking changes to the intended API of RmqThreadCommunicator. I'm putting back tests that check for the intended API which will be fixed in due time.