aiidateam / kiwipy

A python messaging library for RPC, task queues and broadcasts
https://kiwipy.readthedocs.io
Other
15 stars 4 forks source link

`RmqThreadCommunicator`: remove deprecated `start` and `stop` methods #125

Closed sphuber closed 1 year ago

sphuber commented 1 year ago

These were deprecated since v0.6.0 and were slated to be removed for v0.7.0.

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.54% // Head: 89.65% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (60ca66e) compared to base (b78bbe9). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ========================================== + Coverage 89.54% 89.65% +0.12% ========================================== Files 15 15 Lines 1137 1130 -7 ========================================== - Hits 1018 1013 -5 + Misses 119 117 -2 ``` | [Impacted Files](https://codecov.io/gh/aiidateam/kiwipy/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [src/kiwipy/rmq/threadcomms.py](https://codecov.io/gh/aiidateam/kiwipy/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-c3JjL2tpd2lweS9ybXEvdGhyZWFkY29tbXMucHk=) | `88.82% <ø> (+0.77%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.