search

aiidateam / kiwipy

A python messaging library for RPC, task queues and broadcasts
https://kiwipy.readthedocs.io
Other
15 stars 4 forks source link

Revert "Increase the default TTL for task messages (#59)" #93

Closed sphuber closed 3 years ago

sphuber commented 3 years ago

Fixes #92

This reverts commit 42fb6f893c4bd150757e0cd0cef8c6b195b00007.

Changing the TTL of messages of the task queue was necessary because the original value of 7 days was not sufficient for the AiiDA use case. However, when this parameter is changed, one cannot connect to an existing queue that was configured with the old value. The only way is to destroy the queue and create a new one. Since this is not feasible through a Python API, let alone in an automated fashion, this will render all upgraded AiiDA installations completely broken. The only solution is to temporarily revert it to the original value.

sphuber commented 3 years ago

@muhrin as explained in the linked issue, this reverted change somehow was not also merged into develop after it was releasesd in 0.5.5. Officially that means that 0.6.0 and 0.6.1 are also broken, but that is a version that was never used in a released version of aiida-core. The develop branch currently specifies kiwipy~=0.6.1 but since it hasn't been released I am tempted to only fix this for v0.7 and release it in v0.7.1. I can then simply update the requirement in aiida-core. Or do you think we should also fix this for the v0.6 support branch?

muhrin commented 3 years ago

Hmm..yeah, this is frustrating. Does AiiDA expose this TTL through the settings or is it forced to use the kiwipy default? As for creating a support release, I'd almost be tempted to way and see if anyone requests it...I presume someone on aiida develop would think to post an issue.

sphuber commented 3 years ago

Hmm..yeah, this is frustrating. Does AiiDA expose this TTL through the settings or is it forced to use the kiwipy default?

No this is not configurable and so only the kiwipy default is ever used.

As for creating a support release, I'd almost be tempted to way and see if anyone requests it...I presume someone on aiida develop would think to post an issue.

OK, fair enough. I also think it won't be necessary until someone asks for it. Will just do this one then for the time being.