aiidateam / plumpy

A python workflows library that supports writing Processes with a well defined set of inputs and outputs that can be strung together.
https://plumpy.readthedocs.io
Other
8 stars 17 forks source link

Catch `ChannelInvalidStateError` in process state change #278

Closed sphuber closed 11 months ago

sphuber commented 11 months ago

In Process.on_entered, the Communicator.broadcast_send method is called to broadcast the state change to subscribers over RabbitMQ. This can throw a ChannelInvalidStateError in addition to the ConnectionClose exception that was already being caught, in case there is a problem with the connection.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (98a375f) 90.72% compared to head (a7b75f1) 90.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## support/0.21.x #278 +/- ## =============================================== Coverage 90.72% 90.72% =============================================== Files 22 22 Lines 2995 2995 =============================================== Hits 2717 2717 Misses 278 278 ``` | [Files](https://app.codecov.io/gh/aiidateam/plumpy/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [src/plumpy/processes.py](https://app.codecov.io/gh/aiidateam/plumpy/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-c3JjL3BsdW1weS9wcm9jZXNzZXMucHk=) | `92.47% <50.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.