The changes should be functionally equivalent, except for the isinstance checks with 'basestring', which have been replaced with 'str' checks. These no longer accept 'bytes'. However, the subsequent code tries to ''.join(...) these objects, which does not work for bytes.
Following the discussion in #31, that particular piece of code should be removed in a next PR anyway.
greschd
commented
4 years ago
The changes should be functionally equivalent, except for the
isinstancechecks with'basestring', which have been replaced with'str'checks. These no longer accept 'bytes'. However, the subsequent code tries to''.join(...)these objects, which does not work for bytes.Following the discussion in #31, that particular piece of code should be removed in a next PR anyway.