aiidateam / qe-tools

A set of useful tools for Quantum ESPRESSO
MIT License
29 stars 14 forks source link

Allow for emtpy strings in `str2val` #65

Closed sphuber closed 1 year ago

sphuber commented 1 year ago

One of the regexes in str2val did cover for strings covered in single or double quotes, but it required at least 1 character between the quotes. This would cause an empty-string to raise a ValuError.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (5f1f458) 89.87% compared to head (c489a2a) 89.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ======================================= Coverage 89.87% 89.87% ======================================= Files 10 10 Lines 464 464 ======================================= Hits 417 417 Misses 47 47 ``` | [Files](https://app.codecov.io/gh/aiidateam/qe-tools/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [src/qe\_tools/parsers/\_input\_base.py](https://app.codecov.io/gh/aiidateam/qe-tools/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#diff-c3JjL3FlX3Rvb2xzL3BhcnNlcnMvX2lucHV0X2Jhc2UucHk=) | `88.21% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.