search

aik099 / CodingStandard

The PHP_CodeSniffer coding standard I'm using on all of my projects
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Missing tokens #100

Closed gmponos closed 5 years ago

gmponos commented 7 years ago

Missing tokens caused parenthesis to go to new keyword

aik099 commented 7 years ago

Please also update tests/fixtures to cover changed code.

gmponos commented 7 years ago

I am not sure why scrutinizer is failing.

aik099 commented 5 years ago

@gmponos , I'm not sure why this branch deleted OR that it wasn't GitHub automatic response to the force push of master branch.

gmponos commented 5 years ago

Hello,

I closed and deleted the branch.. It was long enough open.. I think this is included to official codesniffer.. maybe I am wrong.. but never the less at some point it must be included because it is required by PSR-12

https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md#4-classes-properties-and-methods

So if it is not included it will be a good chance for you to commit it there and keep working on that one.