search

aik099 / CodingStandard

The PHP_CodeSniffer coding standard I'm using on all of my projects
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Submit BlankLineBeforeReturnSniff to CodeSniffer core #71

Closed fonsecas72 closed 9 years ago

fonsecas72 commented 9 years ago

Hi I see you have a nice BlankLineBeforeReturnSniff which I would like to use for the symfony coding standard but I doesn't exists it in the codeSniffer's core. I think it would add value to the core. Did you ever tried to submit it for the Generic standard maybe?

aik099 commented 9 years ago

I see you have a nice BlankLineBeforeReturnSniff which I would like to use for the symfony coding standard but I doesn't exists it in the codeSniffer's core.

In fact I've got the idea from one of Symfony2-coding-standard repos out there, but I did a complete rewrite afterwards because of the issues I had with original sniff executed on my codebase.

Did you ever tried to submit it for the Generic standard maybe?

I do occasionally.

There are some issues with that sniff, that needs to be fixed before I can do anything: #68

fonsecas72 commented 9 years ago

I see, thanks :)