search

aik099 / CodingStandard

The PHP_CodeSniffer coding standard I'm using on all of my projects
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Unique errors in PHP 5.3 build #89

Closed aik099 closed 8 years ago

aik099 commented 8 years ago

The PHP 5.3 build has 2 unique errors, that other builds don't have: https://travis-ci.org/aik099/CodingStandard/jobs/100773227

There were 3 failures:

1) CodingStandard_Tests_Commenting_FunctionCommentUnitTest::testStandard
[LINE 17] Expected 1 error(s) in FunctionCommentUnitTest.3.inc but found 0 error(s).

/home/travis/build/aik099/CodingStandard/TestSuite/AbstractSniffUnitTest.php:115

2) CodingStandard_Tests_Commenting_InlineCommentUnitTest::testStandard
[LINE 106] Expected 1 error(s) in InlineCommentUnitTest.inc but found 0 error(s).
Failed to fix 2 fixable violations in InlineCommentUnitTest.inc.
Failed to fix 2 fixable violations in InlineCommentUnitTest.js.

/home/travis/build/aik099/CodingStandard/TestSuite/AbstractSniffUnitTest.php:115

3) CodingStandard_Tests_NamingConventions_ValidFunctionNameUnitTest::testStandard
[LINE 196] Expected 1 error(s) in ValidFunctionNameUnitTest.inc but found 0 error(s).

/home/travis/build/aik099/CodingStandard/TestSuite/AbstractSniffUnitTest.php:115

The 2nd error is from #87 issue.

aik099 commented 8 years ago

Closed via e13a7d4e1733d20527f629c326e51ad6335a6976.

Issue was related to the https://github.com/squizlabs/PHP_CodeSniffer/commit/ff53e42039a64d524adc414c1b6433c1e0dc8ef8 commit.