search

aik27 / inwidget

inWidget - free Instagram widget for your website. Allows you to show photos from an Instagram account, by hashtags and more.
http://inwidget.ru
Other
131 stars 53 forks source link

A bit of internationalization and modernization #1

Closed iamwavecut closed 10 years ago

iamwavecut commented 10 years ago

?

aik27 commented 10 years ago

Nice work, thanks! But short tags may not be supported on the target server. I think, it is not good practice for portable, redistributable code.

iamwavecut commented 10 years ago

http://php.net/manual/en/language.basic-syntax.phpmode.php Starting with PHP 5.4, short echo tag <?= is always recognized and valid, regardless of the short_open_tag setting.

aik27 commented 10 years ago

Are all servers in Internet use PHP 5.4 or newer? I don't think so. Especially about shared hosting, for this moment. Yes, I speak like a old grandmother, but when I choose between small things "<?=" and "<?php echo", last option seems better for compatibility.

iamwavecut commented 10 years ago

Reverted to PHP <5.4 style. Also few cosmetics.

aik27 commented 10 years ago

Last commit have a few syntax errors like "<php"

iamwavecut commented 10 years ago

Yep, mass replace mistake. Fixed