search

aikar / commands

Java Command Dispatch Framework - (Bukkit, Spigot, Paper, Sponge, Bungee, JDA, Velocity supported, generically usable anywhere)
https://acfspigot.emc.gs
MIT License
569 stars 147 forks source link

Feature Request: MiniMessage Support in ACF Messaging System #410

Open UnlimitedBytes opened 3 months ago

UnlimitedBytes commented 3 months ago

First and foremost, I would like to extend my heartfelt gratitude to all the contributors of this incredible Command Framework, both past and present. Your hard work and dedication are greatly appreciated!

Request Overview

I am requesting the addition of MiniMessage support within the messaging system of ACF. This enhancement would enable messages to be formatted using modern standards, specifically leveraging Message Components, which have become the new norm for Minecraft messaging.

Current Limitation

At present, the messaging system — or more precisely, the message formatting system — lacks the capability to utilize Message Components. This limitation hinders the adoption of modern messaging standards.

Proposed Solution

I propose to:

Integrate MiniMessage Component Serialization into the MessageFormatters. Update existing translations to be compatible with MiniMessage formatting.

I am willing to contribute by submitting a PR to implement these changes and resolve this issue comprehensively.

Request for Confirmation

Before proceeding, I would like to ensure that this feature would be accepted and merged into the project. A quick confirmation from the project maintainers would suffice, and I will then proceed with the development and submission of the PR.

Thank you for considering my request. I look forward to your response and the opportunity to contribute to this fantastic project.

Best regards, UnlimitedBytes

Wupin commented 1 week ago

You can use the LegacyComponentSerializer as shown here: https://github.com/AuroraNetworkStudios/Aurora/blob/main/src/main/java/gg/auroramc/aurora/commands/CommandManager.java, but it would be better if MiniMessages were supported natively.