aiken-lang / aiken

A modern smart contract platform for Cardano
https://aiken-lang.org
Apache License 2.0
454 stars 84 forks source link

Dashes in folder names or file names breaks the lsp #885

Closed MicroProofs closed 5 days ago

MicroProofs commented 5 months ago

What Git revision are you using?

What operating system are you using, and which version?

Describe what the problem is?

Dashes in folder names or file names breaks the lsp jump to definition and hover to see types.

What should be the expected behavior?

Aiken should be agnostic to whether or not a dash or underscore is used.

Riley-Kilgore commented 1 month ago

Module names are converted, a comment says that both the \\ / and - _ conversions are for windows consistency.

I am not sure that Windows actually requires _ vs - in filenames and directories.. Either way this should be easily remedied and I can create a PR. IFF there is a requirement to leave the conversion as is, I will simply add it to where we resolve the module name that we are looking for. @KtorZ @rvcas @MicroProofs

rvcas commented 1 month ago

@Riley-Kilgore all dashes can be replaced with underscores

KtorZ commented 5 days ago

Fixed in #988