search

aikoven / typescript-fsa-redux-saga

TypeScript FSA utilities for redux-saga
MIT License
61 stars 4 forks source link

Moved deps to peerDeps, support for redux-saga 1.0.0-beta.0 #7

Closed MJLHThomassen-Eurocom closed 6 years ago

MJLHThomassen-Eurocom commented 6 years ago

Fixes #6

I couldn't run the test because of an issue with tape on my Windows machine. I assume everything will still work since im using the code with redux-saga@1.0.0-beta.0 myself now.

aikoven commented 6 years ago

Please see the failing build. I guess these peer deps need to be added to devDependencies as well.

MJLHThomassen-Eurocom commented 6 years ago

Should be fixed now

aikoven commented 6 years ago

I'm sorry, I looked at it again and I doubt that redux-saga is a peer dependency of this lib since it imports redux-saga.

I think #6 could be fixed by just expanding the version range of redux-saga in dependencies.

MJLHThomassen-Eurocom commented 6 years ago

Alright, then ill make that change and do a new PR. I'm not a package dev myself so i dont really know when it should be a dependency and when it should be a peerDependency, I trust your judgement on this.