aiktb / FuriganaMaker

🔳 A browser extension that adds furigana to Japanese text on any page, for learning kanji pronunciation.
https://furiganamaker.app
MIT License
69 stars 7 forks source link

Not working on an AWS Doc #221

Closed manoger closed 2 months ago

manoger commented 2 months ago

Describe the bug

Hello! The content in https://catalog.workshops.aws/well-architected-sustainability/ja-JP/0-region-selection does not produce furigana

Reproduction

  1. Access the website try to show furigana with the extension on Google Chrome

Expected behavior

Expected to show furigana

Browser

Chrome

System Info

No response

Additional context

No response

Validations

aiktb commented 2 months ago

Hi! Thanks for your feedback. I checked the webpage structure of AWS Doc and found that it was not correctly marked as a Japanese webpage, so the extension didn't automatically add furigana to it.

image

Solution: Since this extension obtains the target text through [lang='ja'], on pages that do not have the lang attribute correctly marked, you need to manually add a custom rule to automate it:

domain: catalog.workshops.aws
selector: body *

After testing, the effect of body * is better...

Steps: image image

Note: You may need to re-add this rule soon, as I'm planning to rewrite the rule editor to make it simpler and support including/excluding pages, and I may introduce breaking changes in the process.