Quick code review

[Rafiot]

• [x] Use the with ... as format to open files (https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files)
• [x] Use Formatted String Literals (https://docs.python.org/3/tutorial/inputoutput.html#formatted-string-literals) instead of .format and concatenation
• [x] Use methods/classes to make the code more readable, use if __name__ == '__main__': (Example: https://github.com/Lookyloo/lookyloo/blob/main/bin/async_capture.py)
• [x] Careful with accessing directory by index when they might be empty
  • Even if you're using try ... except, it will not fail but might hide issues you actually want to fix.
• [x] Avoid print, and use the logging module for messages that are useful to the user (https://docs.python.org/3/howto/logging.html)
• [x] Use poetry (https://python-poetry.org/) to package the project, or at least have a requirements file with the dependencies

[FBroy]

Thank you very much for the review! I've adapted the ticked proposals in the last commit.

For the remaining 2:

• I'm not sure where I would use classes in this project, I think that's a bit of an overkill here.
• For the access by index, do you mean this line? browser.find_elements_by_name('button')[0].click()

[Rafiot]

Fair, classes/functions would only make sense if you want to make it a library, and I'm not sure it's the plan. I guess it will depends what you're going to do with the project on the long run. I like the classes/methods approach because it makes it easier to comment describe what's going on, and keeps the scripts more readable. But again, if you're not planning to have the code used as a library, it makes little sense.

Yeah, I mean these kind of calls, or that one: https://github.com/ail-project/ail-feeder-activity-pub/blob/master/bin/feeder.py#L278 The empty dictionary case should not happen, but you always, sometimes, ends up in a situation where does, the script fails and it's a bit annoying. So it's better to just have a check before.

[FBroy]

I'll add a check for those and notify you. Thanks again!