ail-project / lacus

Lacus is a capturing system using playwright, as a web service.

BSD 3-Clause "New" or "Revised" License

39 stars 3 forks source link

Update README.md #12

Closed darkcode357 closed 1 year ago

darkcode357 commented 1 year ago

Description

This pull request aims to perform a documentation review

Type of change

[x] This change a documentation update

Test Configuration:

Firmware version: 1.6.0
Hardware: gitlab_runner
features: all features passed to the gitlab_runner
SDK: python3.8,3.9,3.10,3.11

Checklist:

[x] Fixed contents: in lacus/README.md

issues closed

close #10

@Rafiot

darkcode357 commented 1 year ago

please review @adulau @Rafiot @gallypette @SteveClement

Rafiot commented 1 year ago

I added a comment in the previous PR on that same file, you didn't implement them in this PR.

Whoever is behind this account, please review the changes your AI generates before asking us to do any kind of code review and merge the code.

In this one, the sections headers aren't even correct (you're using ## before using ###).

darkcode357 commented 1 year ago

In moral, man, if you don't know how to differentiate an AI from a human being, there's no reason for me to try to help. I'm trying to contribute to the project, but you're being extremely rude to me.

I implemented the documentation in the readme, documented all the code, did a code review, pointed out points for improvement and was willing to help. However, due to your lack of consideration, politeness, and empathy for others, I am withdrawing from contributing to this project.

Honestly, I expected more from an intelligence center in dealing with people and following good practices in technical operations. At this point I am only referring to you as I don't know the other people involved.

@Rafiot @adulau @gallypette @SteveClement

vncloudsco commented 5 months ago

@Rafiot Why not update the installation instructions? I felt terrible about the software's instructions and this one is really the solution , don't understand why it was rejected?

adulau commented 5 months ago

@vncloudsco Indeed there are some good part with the back-end management which should be in the README.

Rafiot commented 5 months ago

It was rejected because most of the command listed there were wrong and should not be used (they're executed by start.py and having it in the readme was confusing)

What is missing in the readme? The install guide for redis in pointing to https://www.lookyloo.eu/docs/main/install-lookyloo.html#_install_redis and the rest of the install is in the readme. I admit we could add the details for redis in the readme, but none of the rest is useful.

Can you please open a new issue describing the problems you're having?