search

ail-project / lacus

Lacus is a capturing system using playwright, as a web service.
BSD 3-Clause "New" or "Revised" License
43 stars 3 forks source link

Installation guide is only meant to be run from main branch? #19

Open ajoga opened 3 months ago

ajoga commented 3 months ago

Hello,

I'm following the guide to install this, but with a twist as I checkout the latest tag in order to not run from the main branch. Is this unsupported and shouldn't be done, or wasn't considered?

I do my best to run known releases of things, but let me know if this shouldn't be done here.

OS: Ubuntu 22.04.4 LTS

Steps to reproduce:

1/ install AIL 2/ 

$ pwd # ensure you're in the AIL directory
$ sudo apt install pipx
$ pipx install poetry # recommended way to install poetry, by poetry: https://python-poetry.org/docs/
$ pipx ensurepath
$ git clone https://github.com/ail-project/lacus.git
$ cd lacus
$ git checkout v1.10.0 # latest release at time of writing this
$ poetry install
$ poetry shell
$ playwright install-deps
$ echo LACUS_HOME="`pwd`" >> .env
$ poetry run update --init
No logging config file available.
Falling back on sample config, please initialize the logging config file.
* Update repository.

You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

I think it comes from https://github.com/ail-project/lacus/blob/2482a07e59d46517f57efcbe259f2c93afe7c568/bin/update.py#L72

Thank you

Rafiot commented 3 months ago

It's just not been considered. I'm in the middle of something else right now, so I won´t be able to implement a way to optionally track the tag instead of the main branch only today, but that would be a good addition.