PhongTaKiai commented 9 months ago

close: #3
close: #19

https://github.com/ailab-dev/app_buy_sell/assets/117698659/7c95b550-a30b-434b-9aee-f9cb0e18a5f3

mafreud commented 9 months ago

@rick1919 UIは問題ありませんか？ @PhongTaKiai Could you send review request to @rick1919 first for design review? After his approval, please send me review request.

PhongTaKiai commented 9 months ago

@mafreud I'm not collaborator, so I can't send review request

mafreud commented 9 months ago

@PhongTaKiai Sorry, just create a issue comment with mention please.

mafreud commented 9 months ago

@PhongTaKiai First, please fix merge conflicts.

rick1919 commented 9 months ago

@mafreud @PhongTaKiai The UI looks LGTM!

mafreud commented 9 months ago

@PhongTaKiai For now, pulling data from appStore is not necessary. Could you delete it?

Trangkiai commented 9 months ago

@rick1919 @mafreud お世話になっております。念のためコメントについて確認させていただきます。 Issue 18：Appstoreから自動で情報を取得するも今回対応すると認識しておりますが、合っていないですかね？ご確認いただけますと幸いです。

rick1919 commented 9 months ago

@Trangkiai @mafreud 時差があるので僕が対応します。

一旦対応しないで大丈夫です！審査後に追加開発する形での対応お願いします。青木さんとの認識が間違っていなければ、バグ発生リスクが上がってしまうので今回はsroreから自動で情報を取得する機能の開発は除いたほうがいいと考えております。

先に他の機能開発をしていただけると嬉しいです。

@PhongTaKiai Due to the increased risk of bugs,I would like to the development to be done after the release. If my understanding is correct...

Trangkiai commented 9 months ago

@rick1919 cc @mafreud ご説明いただきありがとうございました。承知いたしました。では、sroreから自動で情報を取得する機能を除きます。

Trangkiai commented 9 months ago

Sato san nhắn: Đối ứng chức năng này khả năng mất tgian thêm nên tạm thời tôi sẽ đối ứng. Tạm thời các bạn chưa cần đối ứng cũng được nhé. Nhờ các bạn đối ứng thêm sau khi app được up lên kiểm tra. Nếu ý kiến không đồng nhất với anh Aoki thì khả năng xảy ra bug sẽ cao nên lần này chưa phát triển chức năng này thì hơn. Nhờ bạn đối ứng các chức năng khác trước.

Trangkiai commented 9 months ago

@mafreud お疲れ様です。フォンさんはsroreから自動で情報を取得する機能を削除いたしました。早速のご確認いただけますと助かります。お手数をおかけしますが、よろしくお願い申し上げます。

mafreud commented 9 months ago

@PhongTaKiai Could you update simulator mp4?

PhongTaKiai commented 9 months ago

https://github.com/ailab-dev/app_buy_sell/assets/117698659/72376a7e-a7b0-414d-9785-4adb6067d60b

@mafreud I uploaded video

rick1919 commented 9 months ago

@mafreud @PhongTaKiai The UI is LGTM!

mafreud commented 9 months ago

@PhongTaKiai My review may be strict, but please follow this for a better app. cc: @rick1919

rick1919 commented 8 months ago

@PhongTaKiai @Trangkiai

お疲れ様です。上記の通りに、「もっと見る」のデザインを以下のデザインのように変更する可能でしょうか？箇条書きのような書き方です。

こちらそんなに時間かからないようでしたらお願いします！

rick1919 commented 8 months ago

@PhongTaKiai @Trangkiai How is the progress on this?

Trangkiai commented 8 months ago

@PhongTaKiai @Trangkiai How is the progress on this?

@rick1919 @mafreud 本機能の対応を完了致しました。チェックお願い致します。

mafreud commented 8 months ago

@PhongTaKiai, Could you show us the updated UI of ExpansionTile?

Trangkiai commented 8 months ago

@rick1919 @mafreud 本日のミーティングありがとうございました。以下のビデオをご確認お願い致します。 https://github.com/ailab-dev/app_buy_sell/pull/17#issuecomment-1931362144

mafreud commented 8 months ago

@Trangkiai 最新のコミットを反映させたビデオをお願いします。

PhongTaKiai commented 8 months ago

https://github.com/ailab-dev/app_buy_sell/assets/117698659/66c47ee0-c0b9-46ef-bf6f-521cab636839

@mafreud this latest video, thank you

Trangkiai commented 8 months ago

@rick1919 @mafreud フォンさんは上記の通りにビデオをアップしました。ご確認いただけますと幸いです。

rick1919 commented 8 months ago

@PhongTaKiai @mafreud @Trangkiai What is the difference between this video and that one? https://github.com/ailab-dev/app_buy_sell/pull/17#issuecomment-1931362144

rick1919 commented 8 months ago

@PhongTaKiai @mafreud @Trangkiai The UI is LGTM!

mafreud commented 8 months ago

@PhongTaKiai Please remove close link #18 and #19 since you don't solve them.

PhongTaKiai commented 8 months ago

@PhongTaKiai Please remove close link #18 and #19 since you don't solve them.

I removed #18,

19 has been implemented

PhongTaKiai commented 8 months ago

@mafreud I fixed comments

ailab-dev / app_buy_sell

product detail #17

19 has been implemented