search

ailabstw / go-pttai

⛔️ [DEPRECATED] Current development in https://github.com/ailabstw/pttai-next
https://ptt.ai
GNU Lesser General Public License v3.0
28 stars 8 forks source link

remove or update dependency `github.com/Azure/azure-storage-go` #253

Open poga opened 5 years ago

poga commented 5 years ago

Version information:

InitApp: start theVersion 0.2.0 gitCommit e04f1cae871b06fd7a661cb0a5ee539b646f8a56 Gptt Version: 0.2.0 Git Commit: e04f1cae871b06fd7a661cb0a5ee539b646f8a56 Architecture: amd64 Go Version: go1.12.2 Operating System: darwin GOPATH= GOROOT=/usr/local/Cellar/go/1.12.2/libexec

Type:

Bug

Description:

internal/build/azure.go depends on github.com/Azure/azure-storage-go. But the upstream module is split to separated packages (see https://github.com/Azure/azure-storage-blob-go/issues/35). To migrate to go mod, we need to fix this dependency or we're locked to the vendored version.

Questions:

chhsiao1981 commented 5 years ago

This was part of ethereum-code～ It was used for ethereum-deployment to azure～

We don't need this feature and we can remove all the related code～