Setting requestedOrientation to ActivityInfo.SCREEN_ORIENTATION_PORTRAIT may cause incompatibility on large screen devices

ailabstw / social-distancing-android

Taiwan Social Distancing App - Android

https://play.google.com/store/apps/details?id=tw.gov.cdc.exposurenotifications&hl=zh_TW&gl=US

MIT License

91 stars 57 forks source link

Setting requestedOrientation to ActivityInfo.SCREEN_ORIENTATION_PORTRAIT may cause incompatibility on large screen devices #13

Open seventhmoon opened 3 years ago

seventhmoon commented 3 years ago

https://github.com/ailabstw/social-distancing-android/blob/c7179d943bc242a8eca2fd1cc4eda0f62523e7b3/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/BaseActivity.kt#L25

Any reason of forcing portrait mode? It is possible that if a foldable device unfold, the screen will be in landscape mode.

Ref: https://developer.android.com/guide/topics/ui/foldables

catcutecat commented 3 years ago

The only reason is we did not have a proper landscape UI design yet. Allowing landscape mode directly will produce bad UI on some pages, and we do not have enough time to test landscape mode in previous versions.

But I think we may provide landscape mode in the future version :D