search

ailiboy / ebookdroid

Automatically exported from code.google.com/p/ebookdroid
0 stars 0 forks source link

NPE in SurfaceView.redrawView #180

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
the below code in SurfaceView.redrawView has NPE issue

    @Override
    public final void redrawView(final ViewState viewState) {
        if (viewState != null) {
            if (drawThread != null) {
                drawThread.draw(viewState);
            }
            final DecodeService ds = base.getDecodeService();
            if (ds != null) {
                ds.updateViewState(viewState);
            }
            base.getDecodeService().updateViewState(viewState);
        }
    }

The last line should be deleted.

r1060 from refactoring branch

Original issue reported on code.google.com by coolspac...@gmail.com on 16 Mar 2012 at 7:19

GoogleCodeExporter commented 9 years ago 
last one?
pls provide the full  patch

Original comment by Alexander.V.Kasatkin@gmail.com on 16 Mar 2012 at 7:42

GoogleCodeExporter commented 9 years ago 
patch is unneeded, because only one line should be change. 
SurfaceView.java line 339, delete this line and that's all I think.

The version of whole branch I use is r1060, but SurfaceView.java has not been 
changed since r1023

Original comment by coolspac...@gmail.com on 16 Mar 2012 at 7:59

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by Alexander.V.Kasatkin@gmail.com on 17 Mar 2012 at 8:42