search

ailisp / commonlisp-vscode

Common Lisp Editing extension for Visual Studio Code
35 stars 1 forks source link

"linedit" requires GCC, add MSVC support. #5

Open Borderliner opened 4 years ago

Borderliner commented 4 years ago

Cannot install ailisp/linedit because it tries to compile its components using GCC, which is not present on Windows without the help of Cygwin and MSYS2. Please add support for MSVC.

ailisp commented 4 years ago

Hi Borderliner! I currently lacking a windows machine, but seems most of the open issues are people from Windows world, will take a look once I install one. If you're interested to take a look, the major problem is get GNU Readline compiled in MSVC, it could be not trivial as it depends on other gnu c libs.

Borderliner commented 4 years ago

@ailisp Is it not possible to ship GNU Readline as a pre-compiled library alongside linedit? It seems that it's quite possible to compile GNU Readline in MinGW-w64.

There is also this, which is provides pre-compiled GNU Readline for Windows.

I also found this, which provides Visual Studio solution for compiling GNU Readline.

ailisp commented 4 years ago

👍 Will do

snunez1 commented 4 years ago

Just an FYI: GNUReadline inclusion might pollute the whole package with GNU licensing. Are there any alternative libraries? Perhaps linedit, which has the advantage of being in Lisp too.

ailisp commented 4 years ago

Thanks for the info! ailisp/linedit is a fork of sharplisper/linedit (only added some minor formatting tweaks), and sharplisper/linedit depends on cffi + GNU Readline, so it's not easy to skip unless there's a non GPL GNUReadline alternative, but i'm fine to have turn cl-lsp to GPL

snunez1 commented 4 years ago

Ah I didn't notice you were using linedit.

One note, if you do include GNU Readline, please consider keeping cl-lsp non-GNU and allowing the infection to flow through via the GNU library. That way it's possible for someone to rewrite the readline bits if they want to. Many of us are prohibited from using copyleft libraries.

Borderliner commented 3 years ago

@ailisp Is it possible for you to swap out GNUReadline with non-GPL alternatives like:

snunez1 commented 3 years ago

libedit is supposed to be a drop-in replacement. Nice find.

On Tue, Oct 20, 2020 at 5:54 AM Ryan Hajianpour notifications@github.com wrote:

@ailisp https://github.com/ailisp Is it possible for you to swap out GNUReadline with non-GPL alternatives like:

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ailisp/commonlisp-vscode/issues/5#issuecomment-712463735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3KJ4GHVFBA2KIB5XBDDSLSLSYSBANCNFSM4P3SKIBA .

ailisp commented 3 years ago

wrap libedit with cffi and make cl-lsp depends on that, low priority but contributions is welcome. Also https://github.com/koji-kojiro/cl-repl/issues/50 is fixed, which makes cl-repl a better user experience alternative, i'm going to prioritize using it to replace cl-lsp

Borderliner commented 3 years ago

Thank you. Unfortunately I'm not very experienced with CL. I would've helped otherwise.