Adding phone OS versions and resolutions

ailon / PhoneNameResolver

Helps resolve actual reported Windows Phone model names to their "canonical" (publicly known) form.

MIT License

67 stars 26 forks source link

Adding phone OS versions and resolutions #2

Closed tpetrina closed 3 years ago

tpetrina commented 11 years ago

Hi,

I need to know how large (in inches) the screen is for which phone and I thought you might want to incorporate this info.

I kept the changes to a minimum, but maybe CanonicalPhoneName has different meaning in my version.

Anyway, tell me if you like the pull.

Cheers Toni

ailon commented 11 years ago

Hmm... While this feels like valuable info in some cases, I don't think it makes sense to modify name resolution to include all the extra info and repeat all that info for each name variation. I think it would make way more sense to have a separate project that would incorporate PhoneNameResolver and return all that extra device info based on the CanonicalPhoneName passed to it.