Closed RayStick closed 1 week ago
@BatoolMM @Rainiefantasy @DDelbarre - it would be great to get at least 2 of you reviewing this PR if that's possible, as it's a relatively major change for a user interaction, so I want to double check all is working fine and it cannot be broken in a way that I have not anticipated. After this PR is merged, I intend to make a new package release.
Thanks in advance :rocket:
Just to note: there have been a fair few changes to the code lately based on @DDelbarre's suggestions and @Rainiefantasy's review of these PRs. Main ones here:
@Rainiefantasy thanks for the helpful testing so far 🚀
output_dir
and user specified output_dir
:white_check_mark: :x: only works for me - we need to investigate furtheroutput_dir
is relative as well as absolute (and with or without /
at end)
:white_check_mark: :white_check_mark: works for both of usFYI seems like all is working - point 2 was erroring before but works fine now. I.e. all changes are working as expected 🤞
@BatoolMM and @DDelbarre I am merging for now, as Mahwish & I did a fair bit of testing and troubleshooting. Would still value any user testing you have time for in the future
Thank you @Rainiefantasy @RayStick - thsi looks wonderful - I did a very quick test and it seems to be working well. I have blocked time tomorrow morning to review more.
Amazing - thanks Batool!
Closes #63
Copying from one table to the next will save the user time, and ensure consistency of categorisations across tables
Proposed Changes
domain_mapping
has been added (table_copy
) - see the description of this argument in the function itself and the explanation in the README of what table copying means (particularly lines 348 onwards)domain_mapping
docs in general, to reflect some recent changesIn order to test the code you will need to process multiple tables
This is an example of how the copying should work (ignore the actual domain code values):
Checklist before review: