aim-rsf / browseMetadata

An R package to help a researcher browse metadata for health datasets and categorise variables based on research domains
https://aim-rsf.github.io/browseMetadata/
GNU General Public License v3.0
4 stars 1 forks source link

Graph generated at the very end #108

Open BatoolMM opened 2 months ago

BatoolMM commented 2 months ago

Currently, there is a graph that is generated at the very end that shows the mapping, my questions:

(Not important at this stage but wanted to ask it)

RayStick commented 2 months ago

Thanks Batool!

Currently this is what is in the README:

The PLOT png file saves a simple plot displaying the count of domain codes for that table.

To add more context to why this plot exists, we could expand and say:

The PLOT png file saves a simple plot displaying the count of domain codes for that table. This is the same information captured in the OUTPUT csv - the plot allows a quick way for a user to visualise which domains are represented for this table.

With regard to customizing, I am open to it, but don't want to make it too complicated as it's such a simple plot. Also, if we allow a user to customize, we will need to make sure the plot is still formatted well. At the moment, the simplicity means it should always work. Did you have thoughts on how a user might want to customize? They also have the option of loading the OUTPUT csv in their own code later

BatoolMM commented 2 months ago

Ahh I see - I see. I was reflecting on other functions I've seen before. Since this is a ggplot created from a CSV file, I know it's a very simple one, but I believe there's a way to make it editable as a ggplot. This would allow users to add other layers from ggplot without requiring extra work from you. Visualization is always appealing for users, even if it's very simple. I'll need to think more about this.

RayStick commented 2 months ago

Ah yes, I see what you mean now! Let's return to this later