search

aim-rsf / browseMetadata

An R package to help a researcher browse metadata for health datasets and categorise variables based on research domains
https://aim-rsf.github.io/browseMetadata/
GNU General Public License v3.0
3 stars 1 forks source link

Remove demo mode #40

Closed BatoolMM closed 8 months ago

BatoolMM commented 8 months ago

I have been trying to invoke the demo dataset as default if both arguments aren’t provided. I need to test it - can you review if it gives you an error downstream of the function when you have time @RayStick?

I pushed .RDataby mistake - I will add it to .gitignore.

BatoolMM commented 8 months ago

I had to re-base it, my branch was behind. it's ready for review now!

RayStick commented 8 months ago

Thanks @BatoolMM this is great! I have accepted your changes and also made a few documentation changes to go along with them. I have tested the code and it works as intended by running domain_mapping() now.

RayStick commented 8 months ago

I just merged, hope that was okay @BatoolMM

BatoolMM commented 8 months ago

Sorry, forgot to change it in the README and docs

Thank you for reviewing it!

RayStick commented 8 months ago

No need for apologies, a team effort! I just skipped a couple of steps and made some direct edits haha It all works perfectly though, thanks for the change