aim42 / htmlSanityCheck

Standalone (batch- and command-line) and Gradle-plugin html sanity checker - detects missing images, dead links and cross-references, duplicate link targets (anchors) and the like.
Apache License 2.0
70 stars 47 forks source link

Change default output dir to reports #205

Closed thc202 closed 6 years ago

thc202 commented 6 years ago

The default directory for reports (following the ReportingExtension) is named reports but the HtmlSanityCheckTask task is currently being initialised to report:

https://github.com/aim42/htmlSanityCheck/blob/6f5619748ce4fea87f06f2ca595fb296fc8c1576/src/main/groovy/org/aim42/htmlsanitycheck/HtmlSanityCheckTask.groovy#L63

Would be possible to change the default to reports instead? This is a potential breaking change but fine if done before 1.0.0?

gernotstarke commented 6 years ago

imho nobody so far relies on the directory naming, so we may change it to reports...

thc202 commented 6 years ago

The directory htmlchecks could also be renamed to htmlSanityCheck, for consistency with project/task name.

gernotstarke commented 6 years ago

Thanx for the suggestion, good idea!

done with 134032edef8d79b97df700ca5f90e33d47ff2d79

thc202 commented 6 years ago

Thank you!