search

aim42 / htmlSanityCheck

Standalone (batch- and command-line) and Gradle-plugin html sanity checker - detects missing images, dead links and cross-references, duplicate link targets (anchors) and the like.
Apache License 2.0
70 stars 47 forks source link

Tests: BrokenHttpLinksCheckerSpec is broken #294

Open rdmueller opened 2 years ago

rdmueller commented 2 years ago 
Condition not satisfied:

collector.getFindings().size() == 1
|         |             |      |
|         []            0      false
Checking results for External Links Check
 1 anchor href attribute checked,
 0 finding(s)
[]

    at org.aim42.htmlsanitycheck.check.BrokenHttpLinksCheckerSpec.redirects are recognized and their new location is contained in warning message(BrokenHttpLinksCheckerSpec.groovy:218)

https://github.com/aim42/htmlSanityCheck/blob/master/src/test/groovy/org/aim42/htmlsanitycheck/check/BrokenHttpLinksCheckerSpec.groovy#L205

I guess the old arc42 site has changed so that this test is broken.

ascheman commented 1 year ago

Didn't see this issue but ran into the very same problem - and tried to resolve it with 5fe38a11. Please close the issue, if you consider this a proper fix.