aimacode / aima-javascript

Javascript visualization of algorithms from Russell And Norvig's "Artificial Intelligence - A Modern Approach"
http://aimacode.github.io/aima-javascript/
MIT License
538 stars 216 forks source link

Ch 7 - Logical agents : Wumpus world #154

Open Dragneel7 opened 6 years ago

Dragneel7 commented 6 years ago

Presently, the implementation of the Wumpus world environment is not complete and quite different from what the aima-book aims to potray about logical agents. I am planning on implementing an autonomous logical agent for the wumpus world. I wish to re-implement the environment. @samuelgoto Can I re-write the current code( one generating the environment) so that it can communicate with my code. I am facing a minor issue, it would be really helpful if we can discuss on it.

samuelgoto commented 6 years ago

I'd like to make sure we can discuss design first and code second. I wrote down what I'm looking for in terms of design quality. Procedurally I'm thinking that we want to first design how things are going to go (e.g. in a google document) before we start looking at implementing it (e.g. code).

I'm thinking design first (google doc), prototype second (github page) and code third (PR).

Care to kick off a design doc with how you want to go about this in these terms?

@aimacode/aima-java-team

Dragneel7 commented 6 years ago

I have shared with you a Google doc regarding the same.

Dragneel7 commented 6 years ago

link The is still a work in progress, I have mentioned about the details in the doc.Kindly have a look at them.

samuelgoto commented 6 years ago

I have left you a lot of comments in your design doc. Lets go through that first before prototyping anything.

On Wed, Feb 28, 2018 at 9:58 AM, surya saini notifications@github.com wrote:

link https://dragneel7.github.io/html/wumpus.html The is still a work in progress, I have mentioned about the details in the doc.Kindly have a look at them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aimacode/aima-javascript/issues/154#issuecomment-369325282, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqV6m4ssaxdlm0vp-FcTG612vc-aRO-ks5tZZMMgaJpZM4SR1oZ .

-- f u cn rd ths u cn b a gd prgmr !

Dragneel7 commented 6 years ago

@samuelgoto here is a design doc for the wumpus world visualization. I have looked into the points you pointed out and have suggested a few new ways to make the implementation more user engaging and informative.

anishaswain commented 6 years ago

Hello @Dragneel7 and @samuelgoto, I have also been working on Wumpus World Visualization. Here is my design doc. I will be glad if you could provide some feedback. Thank You

Dragneel7 commented 6 years ago

The idea of not showing the positions of components is good, maybe when the reader goes on we can ask him to construct the environment using the knowledge base he has created.

On Mar 1, 2018 4:47 PM, "ANISHA SWAIN" notifications@github.com wrote:

Hello @Dragneel7 https://github.com/dragneel7 and @samuelgoto https://github.com/samuelgoto, I have also been working on Wumpus World. Here https://docs.google.com/document/d/1LWZwTHcK9167XZ0KFPoXrwpQEA9gBkCcC01C3JEOUK0/edit?usp=sharing is my design doc. I will be glad if you could provide some feedback. Thank You

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aimacode/aima-javascript/issues/154#issuecomment-369560592, or mute the thread https://github.com/notifications/unsubscribe-auth/AXEpPoO-JMpTpdhLTU2sx-S4o2Zs8Qw8ks5tZ9i9gaJpZM4SR1oZ .

anishaswain commented 6 years ago

@Dragneel7 Thanks for your suggestion. That will be a good approach.

Dragneel7 commented 6 years ago

I have improved the design doc, and incorporated the narrative as you pointed out. @samuelgoto Please review. link: here Thanks

anishaswain commented 6 years ago

Hello @samuelgoto, Initially I was a bit confused about the concept of the design doc but this time I have tried to work on your suggestion and recommendations. I have shared a new google doc with you, explaining my ideas to visualize the wumpus world problem.I understand your suggestion of having a design doc before moving on to a prototype but as I had already implemented some part of the visualization, so I tried to combine both prototype images and google diagrams to explain the concept in the design doc.Kindly review it and let me know the further modifications if needed. Thank You