aimacode / aima-julia

Julia implementation of algorithms from Russell And Norvig's "Artificial Intelligence - A Modern Approach"

MIT License

126 stars 50 forks source link

NLP apps notebook #17

Closed utkarsh23 closed 6 years ago

utkarsh23 commented 6 years ago

Resolved #16 This PR creates an IJulia notebook for NLP applications and demonstrates language recognition.

mikhail-j commented 6 years ago

@utkarsh23 Change the local variable type to use AbstractCountingProbabilityDistribution? Make sure the variable is of the correct type when using predict().

i.e.

local attribute_distribution::AbstractCountingProbabilityDistribution = nbsm.attributes_distributions[target];

Overall, good work on the IJulia NLP apps notebook.

utkarsh23 commented 6 years ago

@mikhail-j done :+1:

utkarsh23 commented 6 years ago

Please do not merge this PR just yet. #18 needs to be resolved first after which I might have to update paths to the submodule aima-data.

utkarsh23 commented 6 years ago

18 is closed. You can now merge this PR. :+1: