search

aimacode / aima-julia

Julia implementation of algorithms from Russell And Norvig's "Artificial Intelligence - A Modern Approach"
MIT License
126 stars 50 forks source link

Update 'aima-data' submodule #18

Closed utkarsh23 closed 6 years ago

utkarsh23 commented 6 years ago

I've noticed that the test run-text-test.jl fails because it cannot locate gutenberg.txt inside the submodule aima-data. This is because the aima-data submodule of this repository does not point to the latest commit of aima-data repo. We need to update that. I think only those who have complete access to this repository can update it. Please look into this @norvig @mikhail-j

mikhail-j commented 6 years ago

@utkarsh23 @norvig I checked run_text_tests.jl and the relative path for gutenberg.txt is the most recent (./aima-data/gutenberg.txt 9ba0497).

If you look at run_travis_tests.sh, the travis-ci build clones the aima-data repository with the latest commits.

This means that during Travis-CI testing, both /aima-julia/aima-data and /aima-julia/tests/aima-data exist.

But /aima-julia/tests/aima-data is used by the Base.Test tests in /aima-julia/tests.

The main reason why /aima-julia/aima-data exists as a git submodule is because aima-julia uses it to initialize the machine learning datasets for the machine learning algorithms.

As a result, the git submodule should be updated only if a dataset was moved or added.

utkarsh23 commented 6 years ago

@mikhail-j thanks for the repsonse! Much appreciated! :smile: