search

aimacode / aima-python

Python implementation of algorithms from Russell And Norvig's "Artificial Intelligence - A Modern Approach"
MIT License
8.05k stars 3.81k forks source link

Improvements in agents.py #330

Open kaivalyar opened 7 years ago

kaivalyar commented 7 years ago

While working on updating the docstring in agents.py, I noticed some discrepancies within the code. There were some differences between the algorithms pdf being used as a guide, the hardcopy of the book I have, the table in the README.md file, and agents.py.

For instance: TableDrivenAgent:

Either I seem to be missing some obvious naming conventions/pseudocode sources, or this is a minor error that can be corrected. I have found similar issues regarding many other parts of agents.py, but am unsure if I am correct in assuming these to be errors. Can somebody please verify this, as I have already started working on it?

kaivalyar commented 7 years ago

List of Errors:

  1. Direction.L + Direction.L gives Direction.L (fixed in #348)
  2. Two-dimensional graphs are implemented without proper graphic display in agents.ipynb. (fixed in #350)
  3. The wumpus world implementation currently seems spread out across agents.py and logic.py - this should probably be moved entirely to logic.py as it covers features not introduced in chapter2, which is the core focus of agents.py - although it would be good to discuss this more thoroughly with somebody before making the changes.
  4. (Lots) of missing unit tests.