search

aimalz / proclam

PRObabilistic CLAssification Metrics for PLAsTiCC
Other
12 stars 7 forks source link

Included all changes that were not assigned to Alex #68

Closed reneehlozek closed 6 years ago

reneehlozek commented 6 years ago

Mainly rewriting to address issues of clarity, typos and sentence construction.

reneehlozek commented 6 years ago

I'm going to leave it to you @aimalz to resolve the conflicts.

reneehlozek commented 6 years ago

I am still working on the results section to make sure that our points are clear, but have made changes to the text in the previous sections, including responses to comments from Tina on language and interpretability. Please comment on this PR @aimalz in particular with reference to removing symbols - we want to make sure that folks outside of only the stats community read and engage with this text! I will make changes to the results section tomorrow morning, so please let me know the status of this PR then.

aimalz commented 6 years ago

@reneehlozek Right on! As I've said before, the intended audience is only astronomers, not statisticians, and, as Tom has pointed out, I clearly don't even read statistics papers, so this language doesn't come from there -- the corrections and clarifications are appreciated!

I took a look at the diff and incorporated many of the smaller typographical/linguistic changes. However, your modifications are quite extensive, too much for me to review given that there's a bug in GitHub preventing a proper comparison, even if I didn't have other commitments this week. It would at least have helped if @tinapeters's comments had been made into an issue so I could try to make sense of it without dedicating time I no longer have -- I didn't even know she was trying to give me feedback!

If so many changes were requested, do you think we should check with the Pub. Board, since we told them the last version of (189596d, I think?) was the final version? I don't want them to think we're going to submit a different paper after getting their approval.

reneehlozek commented 6 years ago

Most of the major changes so far are related to rewriting the text for smoothness and clarity (and making it more readable) - a significant number of them are from a week ago. I'm happy to resolve these conflicts - I'm only waiting as you asked me to. I particularly asked @tinapeters to have a read of the paper for clarity given that we've had comments that it is a difficult paper to understand.