search

aimalz / qp

Quantile Parametrization for probability distribution functions module
MIT License
3 stars 9 forks source link

Issue/24/samples #45

Closed aimalz closed 7 years ago

aimalz commented 7 years ago

Not only does the PDF object now perform sampling from any other parametrization, it also can be initialized from samples. The updated demo notebook shows this functionality and calculates statistics.

aimalz commented 7 years ago

Thanks for the suggestions! I took out the limits/points keywords to qp.PDF.plot() and made it adapt the limits to what it's plotting. I also added some text in the demo to explain the samples parametrization and broke up the demo into more subheadings. Does it look any better now?

Edit: I'm going to move forward with the merge but will leave the branch intact in case you have more ideas for changes.

drphilmarshall commented 7 years ago

Yes! Good stuff, Alex.

On Wed, Feb 8, 2017 at 1:39 PM, Alex Malz notifications@github.com wrote:

Thanks for the suggestions! I took out the limits/points keywords to qp.PDF.plot() and made it adapt the limits to what it's plotting. I also added some text in the demo to explain the samples parametrization and broke up the demo into more subheadings. Does it look any better now?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/aimalz/qp/pull/45#issuecomment-278470130, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY91kiTfNQ2TctywsuU4TLWjEhOcotks5rajYkgaJpZM4L7O6F .