search

aimalz / qp

Quantile Parametrization for probability distribution functions module
MIT License
3 stars 9 forks source link

Issue/39/start paper #59

Closed aimalz closed 7 years ago

aimalz commented 7 years ago

Re: #39 the zeroth version of the draft is ready. @drphilmarshall does it look okay to you? Thanks for getting this started!

aimalz commented 7 years ago

Oh, it just occurred to me that the Travis checks won't find errors in the paper. For example, what I just pushed fails upon running make. (I have not yet investigated the cause of the error but will do so immediately.) Should I add compilation of it to the .yml?

drphilmarshall commented 7 years ago

Yes! There should be a .travis.yml that came with the start_paper template that you can copy and paste from to not only build the paper, but also deploy the built PDF back to the base repo in an orphan pdf branch. Good catch!

An important step in this process is to obtain a GitHub API key (see your settings), and paste it into the travis repo settings as an environment variable called GITHUB_API_KEY, that it can look up and use to push the PDF back to GitHub.

aimalz commented 7 years ago

It took me far too long to find the documentation for this procedure, but I think I followed the instructions. Am I correct in understanding that we won't find out for sure if it worked until the branch is merged into master?

drphilmarshall commented 7 years ago

Yes, that's right - I'll review now so you can merge and try it out!

aimalz commented 7 years ago

It looks like after merging this, the .pdf isn't being updated on GitHub (which is corroborated by Travis). I was under the impression that it didn't matter if the changes were made in the .travis.yml in the paper directory rather than the top-level directory (and the rest of the commands there seem to have worked), but I don't have other ideas for what might be wrong.

drphilmarshall commented 7 years ago

I'll take a look and issue a fix. My success rate in getting this to work first time is about 50% :-)