Open thegodone opened 2 years ago
At the moment we worked on crystal graph models. We added CGCNN. I want to add E3GNN or ALIGNN next.
I think E3GNN is a nice addition yes as well as ALIGNN of course
In the paper CMPNN they said Max pooling and in the code you put softmax is there any reason for that change ?
what is still strange for me they take the [0] value there in the product second term
Yeah, sorry I should have put "segment_max". I mixed it up, which is why the error you sent me occured. In attention you have softmax and multiply with edges and then pool via sum. But here it seems that is sumed and afterwards the nodes multiplied with max. I would have to check the tensors to see why they have a [0] here... I run training again...
I just add this paper that you should look at https://pubs.acs.org/doi/10.1021/acs.jctc.1c01021
GemNet is very existing model
I just add this paper that I forget : https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9189862 it's a variant of GIN that is very close to AttFP / Chemprop in performances I tried in the past to make this code in PyG but never finish it: https://github.com/pyg-team/pytorch_geometric/issues/1729
I just Add the RMAT that look like a rbf + envelop improvement over MAT logic
I encourage to do this https://github.com/HannesStark/3DInfomax
https://arxiv.org/pdf/2111.06283.pdf https://github.com/KarolisMart/DropGNN looks very interesting for MPNN / DMPNN / GIN
Reading https://arxiv.org/pdf/2003.00982.pdf I suggest to add the PE versions (aka graph positional encoding) see AQSOL performances Table 4 (GatedGCN-E-PE) => https://github.com/graphdeeplearning/benchmarking-gnns
can you tell me what are the next coming architecture in your pipeline ?
4 topics:
A. transformers:
B. Recursive Graphs:
C. Some finetune versions of existing codes:
D. 3D Equivariants strategies (SE3 => "Chirality friendly" or E => "Achiral ...") essential to have them:
E. Unsuppervised Graph:
=> GemNet is very existing model (*) I think simpler is better so we must focus on low parameter architecture first!