aimclub / FEDOT

Automated modeling and machine learning framework FEDOT
https://fedot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
623 stars 84 forks source link

Support of multimodal data in DataSourceSplitter + bugfix #1119 #1138

Closed kasyanovse closed 11 months ago

kasyanovse commented 11 months ago
  1. Add support of multimodal data to cross validation
  2. Add stratification for classification by default (#1119)
  3. All data splitter function parameters are unified (shuffle_flag in train_test_data_setup was retained for backward compatibility)
  4. Many checks added in DataSourceSplitter and train_test_data_setup
  5. core.validation.split.py module is moved to core.data.cv_folds.py
  6. New tests are added
  7. DataObjectiveAdvisor is deleted because stratification is enable by default
  8. OneFoldInputDataSplit is deleted because cv_generator get checked parameters from DataSourceSplitter. Cross validation always may be done.
  9. Some old tests rely on unstratified samples. DataSourceSplitter and train_test_data_setup are called with stratify=False in that cases.
aim-pep8-bot commented 11 months ago

Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 207:27: E126 continuation line over-indented for hanging indent Line 223:27: E123 closing bracket does not match indentation of opening bracket's line

Comment last updated at 2023-08-14 13:15:41 UTC
codecov[bot] commented 11 months ago

Codecov Report

Merging #1138 (d77ecdb) into master (04bceac) will decrease coverage by 0.12%. The diff coverage is 92.96%.

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   78.62%   78.51%   -0.12%     
==========================================
  Files         131      130       -1     
  Lines        9401     9336      -65     
==========================================
- Hits         7392     7330      -62     
+ Misses       2009     2006       -3     
Files Changed Coverage Δ
fedot/api/api_utils/params.py 89.21% <ø> (-0.11%) :arrow_down:
.../core/optimisers/objective/data_source_splitter.py 92.20% <85.29%> (-3.57%) :arrow_down:
fedot/core/data/data_split.py 94.73% <93.84%> (+3.52%) :arrow_up:
fedot/core/data/cv_folds.py 100.00% <100.00%> (ø)
...tations/data_operations/sklearn_transformations.py 91.20% <100.00%> (ø)
nicl-nno commented 11 months ago

Не забудь только pep8-замечания поправить.

kasyanovse commented 11 months ago

Не забудь только pep8-замечания поправить.

Поправил. Осталось два замечания, но с кодом в указанных местах все нормально.