Closed kasyanovse closed 11 months ago
Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
test/unit/data/test_data_split.py
:Line 207:27: E126 continuation line over-indented for hanging indent Line 223:27: E123 closing bracket does not match indentation of opening bracket's line
Merging #1138 (d77ecdb) into master (04bceac) will decrease coverage by
0.12%
. The diff coverage is92.96%
.
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 78.62% 78.51% -0.12%
==========================================
Files 131 130 -1
Lines 9401 9336 -65
==========================================
- Hits 7392 7330 -62
+ Misses 2009 2006 -3
Files Changed | Coverage Δ | |
---|---|---|
fedot/api/api_utils/params.py | 89.21% <ø> (-0.11%) |
:arrow_down: |
.../core/optimisers/objective/data_source_splitter.py | 92.20% <85.29%> (-3.57%) |
:arrow_down: |
fedot/core/data/data_split.py | 94.73% <93.84%> (+3.52%) |
:arrow_up: |
fedot/core/data/cv_folds.py | 100.00% <100.00%> (ø) |
|
...tations/data_operations/sklearn_transformations.py | 91.20% <100.00%> (ø) |
Не забудь только pep8-замечания поправить.
Не забудь только pep8-замечания поправить.
Поправил. Осталось два замечания, но с кодом в указанных местах все нормально.
train_test_data_setup
was retained for backward compatibility)DataSourceSplitter
andtrain_test_data_setup
core.validation.split.py
module is moved tocore.data.cv_folds.py
DataObjectiveAdvisor
is deleted because stratification is enable by defaultOneFoldInputDataSplit
is deleted becausecv_generator
get checked parameters fromDataSourceSplitter
. Cross validation always may be done.DataSourceSplitter
andtrain_test_data_setup
are called withstratify=False
in that cases.