Closed kasyanovse closed 11 months ago
Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Merging #1144 (6ae8f6c) into master (89ff552) will decrease coverage by
0.21%
. Report is 2 commits behind head on master. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
- Coverage 78.67% 78.47% -0.21%
==========================================
Files 131 130 -1
Lines 9362 9323 -39
==========================================
- Hits 7366 7316 -50
- Misses 1996 2007 +11
Files Changed | Coverage Δ | |
---|---|---|
...lementations/data_operations/ts_transformations.py | 77.65% <100.00%> (-0.77%) |
:arrow_down: |
Speed test. Also some models are speeded up too because they use ts_to_table
function that is implement in module with lagged
.
Results.
polyfit
lagged
+ ridge
polyfit
lagged
+ ridge
Pipeline with ridge spends half of all time for ridge fitting, therefore speed up is not so high.
Replace chain concatenation with pandas by numpy bulk realization.