search

aimclub / FEDOT

Automated modeling and machine learning framework FEDOT
https://fedot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
635 stars 86 forks source link

`from fedot import Fedot` #1179

Closed MorrisNein closed 1 year ago

MorrisNein commented 1 year ago

Можем ли мы себе это позволить? Готовы ли мы к этому важнейшему шагу? Готов ли мир к этому великому дню?

Я считаю, что да, да и да.

aim-pep8-bot commented 1 year ago

Hello @MorrisNein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3:1: F403 'from fedot import ' used; unable to detect undefined names Line 3:1: F401 'fedot.' imported but unused Line 4:1: F401 'fedot.api.Fedot' imported but unused Line 5:1: F401 'fedot.version.version' imported but unused

Line 1:1: F401 'fedot.api.main.Fedot' imported but unused Line 1:33: W292 no newline at end of file

Comment last updated at 2023-10-02 09:21:59 UTC
codecov[bot] commented 1 year ago

Codecov Report

Merging #1179 (59b7dee) into master (88a2264) will increase coverage by 0.25%. The diff coverage is 80.00%.

:exclamation: Current head 59b7dee differs from pull request most recent head aa7fac6. Consider uploading reports for the commit aa7fac6 to get more accurate results

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   79.67%   79.92%   +0.25%     
==========================================
  Files         141      142       +1     
  Lines        9815     9798      -17     
==========================================
+ Hits         7820     7831      +11     
+ Misses       1995     1967      -28
Files Coverage Δ
fedot/__init__.py 100.00% <100.00%> (ø)
fedot/api/__init__.py 100.00% <100.00%> (ø)
fedot/core/pipelines/prediction_intervals/main.py 77.77% <100.00%> (+2.46%) :arrow_up:
fedot/core/pipelines/prediction_intervals/utils.py 69.51% <100.00%> (ø)
fedot/api/fedot_cli.py 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

MorrisNein commented 1 year ago

З.Ы. Проблема не использования init-ов несколько более общая, и хорошо бы сократить пути импорта и для других часто используемых объектов. Но предлагаю начать с "лица" FEDOT, его API.

С остальными объектами может возникнуть проблема циклических импортов, так что разбираться лучше понемногу.