aimclub / FEDOT

Automated modeling and machine learning framework FEDOT
https://fedot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
635 stars 86 forks source link

Switch OneHotEncoder to LabelEncoder #1196

Closed aPovidlo closed 10 months ago

aPovidlo commented 10 months ago

Change default categories encoder as LabelEncoder in preprocessing

valer1435 commented 10 months ago

Только в мастер это не стоит лить, лучше в отдельную ветку

aPovidlo commented 10 months ago

Стоит проверить, работает или нет. Если действительно работает, то хорошо.

Там тесты падали. Как я думал, ветку будут использовать отдельно в экспериментах прежде чем лить в мастер

pep8speaks commented 10 months ago

Hello @aPovidlo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 5:1: F401 'sklearn.preprocessing.LabelEncoder' imported but unused

Line 13:1: E302 expected 2 blank lines, found 1 Line 16:1: E305 expected 2 blank lines after class or function definition, found 1

Line 6:1: F401 'fedot.core.data.merge.data_merger.DataMerger' imported but unused

Comment last updated at 2023-11-21 13:51:32 UTC
nicl-nno commented 10 months ago

В целом те тесты где проверяется размерность выхода можно просто отключить в этой ветке.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70fc033) 79.49% compared to head (ffbf306) 79.39%. Report is 2 commits behind head on master.

:exclamation: Current head ffbf306 differs from pull request most recent head ee20efd. Consider uploading reports for the commit ee20efd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1196 +/- ## ========================================== - Coverage 79.49% 79.39% -0.10% ========================================== Files 145 145 Lines 10022 10022 ========================================== - Hits 7967 7957 -10 - Misses 2055 2065 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aPovidlo commented 10 months ago

Migrate to #1004 Preprocessor acceleration