aimclub / FEDOT

Automated modeling and machine learning framework FEDOT
https://fedot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
619 stars 84 forks source link

add validation on _window_size param in topo extractor #1284

Closed Lopa10ko closed 2 months ago

Lopa10ko commented 2 months ago

This is a πŸ› bug fix.

Summary

Context

fixed integration test failure with: ValueError: Found array with 0 feature(s) (shape=(3, 0)) while a minimum of 1 is required by check_pairwise_arrays.

docu-mentor[bot] commented 2 months ago

πŸ‘‹ Hi, I'm @docu-mentor, an LLM-powered GitHub app powered by Anyscale Endpoints that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed in this PR. If you only want me to look at specific files or folders, you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/" folder and the file "README.md". All good? Let's get started!

github-actions[bot] commented 2 months ago

All PEP8 errors has been fixed, thanks :heart:

Comment last updated at
nicl-nno commented 2 months ago

А ΠΌΠΎΠΆΠ½ΠΎ это ΠΌΠΎΠ΄ΡƒΠ»ΡŒΠ½Ρ‹ΠΌ тСстом ΠΏΠΎΠΊΡ€Ρ‹Ρ‚ΡŒ для надСТности?

Lopa10ko commented 2 months ago

А ΠΌΠΎΠΆΠ½ΠΎ это ΠΌΠΎΠ΄ΡƒΠ»ΡŒΠ½Ρ‹ΠΌ тСстом ΠΏΠΎΠΊΡ€Ρ‹Ρ‚ΡŒ для надСТности?

Π΄Π°, ΠΌΠΎΠΆΠ½ΠΎ ΠΈ Π½ΡƒΠΆΠ½ΠΎ - сдСлаю. (77a9c78)

[!NOTE] Π² Π΄Ρ€ΡƒΠ³ΠΎΠΌ PR планируСтся ΠΏΠΎΡ€Π°Π±ΠΎΡ‚Π°Ρ‚ΡŒ Π² Ρ†Π΅Π»ΠΎΠΌ Π½Π°Π΄ этим тСстом, ΠΏΠΎΡ‚ΠΎΠΌΡƒ Ρ‡Ρ‚ΠΎ Π² послСднСС врСмя Ρ‚ΠΎΠ»ΡŒΠΊΠΎ ΠΎΠ½ ΠΈ ΠΏΠ°Π΄Π°Π΅Ρ‚ ΠΈΠ· ΠΈΠ½Ρ‚Π΅Π³Ρ€Π°Ρ†ΠΈΠΎΠ½Π½ΠΈΠΊΠΎΠ²: ΠΏΠΎ ΠΊΡ€Π°ΠΉΠ½Π΅ΠΉ ΠΌΠ΅Ρ€Π΅ ΠΏΡ€ΠΎΠΊΠΈΠ΄Ρ‹Π²Π°Π½ΠΈΠ΅ NaN ΠΈΠ»ΠΈ float.inf Π² ΠΎΠΏΡ‚ΠΈΠΌΠΈΠ·Π°Ρ‚ΠΎΡ€ явно Π½Π΅ являСтся ΠΎΠΆΠΈΠ΄Π°Π΅ΠΌΡ‹ΠΌ - это вновь ΠΏΡ€ΠΎΠ±Π»Π΅ΠΌΡ‹ ETSModel #1285