nn_models refactoring

[technocreep]

• base_nn_model refactoring
• improved validation

[pep8speaks]

Thanks for update, @technocreep!

• In the file fedot_ind/api/utils/recurrent_image.py:

Line 65:1: E302 expected 2 blank lines, found 1 Line 69:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file fedot_ind/core/architecture/preprocessing/data_convertor.py:

Line 92:13: F841 local variable 'e' is assigned to but never used Line 266:13: F841 local variable 'e' is assigned to but never used Line 488:13: F841 local variable 'e' is assigned to but never used

• In the file fedot_ind/core/metrics/metrics_implementation.py:

Line 74:73: W503 line break before binary operator

• In the file fedot_ind/core/models/base_extractor.py:

Line 16:1: F403 'from fedot_ind.core.metrics.metrics_implementation import ' used; unable to detect undefined names Line 16:1: F401 'fedot_ind.core.metrics.metrics_implementation.' imported but unused

• In the file fedot_ind/core/models/nn/network_impl/inception.py:

Line 104:1: W391 blank line at end of file

• In the file fedot_ind/core/models/nn/network_impl/omni_scale.py:

Line 12:1: F403 'from fedot_ind.core.models.nn.network_modules.other import *' used; unable to detect undefined names Line 16:20: F405 'Module' may be undefined, or defined from star imports: fedot_ind.core.models.nn.network_modules.other Line 36:20: F405 'nn' may be undefined, or defined from star imports: fedot_ind.core.models.nn.network_modules.other Line 37:20: F405 'GAP1d' may be undefined, or defined from star imports: fedot_ind.core.models.nn.network_modules.other Line 42:23: F405 'nn' may be undefined, or defined from star imports: fedot_ind.core.models.nn.network_modules.other Line 125:121: E501 line too long (121 > 120 characters) Line 169:18: F405 'Tensor' may be undefined, or defined from star imports: fedot_ind.core.models.nn.network_modules.other

• In the file fedot_ind/core/models/recurrence/reccurence_extractor.py:

Line 8:1: F403 'from fedot_ind.core.metrics.metrics_implementation import ' used; unable to detect undefined names Line 8:1: F401 'fedot_ind.core.metrics.metrics_implementation.' imported but unused

• In the file fedot_ind/core/operation/interfaces/industrial_preprocessing_strategy.py:

Line 46:121: E501 line too long (121 > 120 characters)

• In the file fedot_ind/core/repository/industrial_implementations/optimisation.py:

Line 346:36: E127 continuation line over-indented for visual indent Line 348:37: E127 continuation line over-indented for visual indent Line 512:5: F841 local variable 'other' is assigned to but never used Line 525:17: F841 local variable 'parent_operation' is assigned to but never used

• In the file fedot_ind/core/repository/model_repository.py:

Line 14:1: F403 'from fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations import *' used; unable to detect undefined names Line 67:36: F405 'PCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 68:41: F405 'FastICAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 69:46: F405 'PolyFeaturesImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 125:20: F405 'ScalingImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 126:26: F405 'NormalizationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 128:30: F405 'ImputationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 130:23: F405 'KernelPCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations Line 254:62: W292 no newline at end of file

• In the file fedot_ind/tools/loader.py:

Line 270:29: F841 local variable 'univariate' is assigned to but never used Line 305:25: F841 local variable 'class_label_list' is assigned to but never used Line 478:53: W503 line break before binary operator Line 489:53: W503 line break before binary operator Line 528:53: W503 line break before binary operator Line 697:33: F841 local variable 'ex' is assigned to but never used Line 704:33: F841 local variable 'ex' is assigned to but never used

• In the file tests/unit/api/main/test_api_main.py:

Line 140:5: F841 local variable 'labels' is assigned to but never used Line 141:5: F841 local variable 'probs' is assigned to but never used Line 145:5: F841 local variable 'curr_backend' is assigned to but never used

• In the file tests/unit/core/operation/transformation/data/test_kernel_matrix.py:

Line 1:1: F401 'json' imported but unused Line 7:1: F401 'fedot_ind.api.utils.path_lib.PATH_TO_DEFAULT_PARAMS' imported but unused Line 56:41: E225 missing whitespace around operator

Comment last updated at 2024-02-22 14:58:09 UTC

[codecov[bot]]

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (fc114be) 56.15% compared to head (143654c) 56.27%. Report is 1 commits behind head on main.

Files	Patch %	Lines
...t_ind/core/models/nn/network_impl/base_nn_model.py	28.91%	59 Missing :warning:
fedot_ind/api/utils/recurrent_image.py	0.00%	22 Missing :warning:
...t_ind/core/models/ts_forecasting/ssa_forecaster.py	55.00%	9 Missing :warning:
.../core/architecture/preprocessing/data_convertor.py	38.46%	8 Missing :warning:
fedot_ind/core/models/nn/network_impl/inception.py	50.00%	7 Missing :warning:
...edot_ind/core/models/nn/network_impl/omni_scale.py	41.66%	7 Missing :warning:
fedot_ind/api/main.py	0.00%	6 Missing :warning:
fedot_ind/core/models/nn/network_impl/resnet.py	0.00%	4 Missing :warning:
...ot_ind/core/architecture/abstraction/decorators.py	0.00%	2 Missing :warning:
...peration/transformation/regularization/spectrum.py	33.33%	2 Missing :warning:
... and 4 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== + Coverage 56.15% 56.27% +0.11% ========================================== Files 102 102 Lines 8946 9004 +58 ========================================== + Hits 5024 5067 +43 - Misses 3922 3937 +15 ``` | [Flag](https://app.codecov.io/gh/aimclub/Fedot.Industrial/pull/120/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aimclub) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aimclub/Fedot.Industrial/pull/120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aimclub) | `56.27% <45.83%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aimclub#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.